I was in NYC last month and was pleased with the Residence Inn New York Manhattan/Times Square. It's at 6th Ave./39th St., walking distance to Times Square/Theatre District/42nd St. subway. Not inexpensive, but they provide free buffet breakfast (better than typical free breakfasts) and the rooms have full-sized fridge, microwave, sink and dishes/cutlery, so you can save money by eating take out food in your room.
http://www.marriott.com/hotels/travel/nycr...an-times-squareHave also stayed at
Courtyard Marriott Manhattan/Fifth Avenue at 40th/5th Ave. Not fancy, but convenient to 5th Ave. shopping.
Have also stayed at
Holiday Inn Midtown/57th. Again, no frills, but walking distance to Broadway and Central Park.
On a cheaper note, I know someone who's stayed at the Best Western President (
http://book.bestwestern.com/bestwestern/pr...pertyCode=33084) right in the middle of Theatre District.
I would also check
Trip Advisor for ratings/reviews of hotels.
Avoid American holiday weekends for better rates at tourist class hotels, although luxury business hotels may be reasonable on holiday weekends (particularly downtown/financial district, but this is not convenient for theatre, shopping, and most tourist attractions, which are mostly in midtown).